Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove volume expose #1560

Merged
merged 17 commits into from
Apr 1, 2020
Merged

Remove volume expose #1560

merged 17 commits into from
Apr 1, 2020

Conversation

gvenzl
Copy link
Member

@gvenzl gvenzl commented Mar 26, 2020

  • Remove VOLUME from Database images
  • Remove EXPOSE from Database images
  • Use LABEL for volume, expose and other information
  • Update Contributing.md with LABEL guidelines
  • Introduce 19c test case
  • Change prebuilt DB image sample

@Djelibeybi, please review everything ;)
@mriccell, please review Contributing.md and an example regarding the label structure.

gvenzl added 9 commits March 25, 2020 14:05
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
@gvenzl gvenzl requested review from Djelibeybi and mriccell March 26, 2020 21:49
Copy link
Member

@Djelibeybi Djelibeybi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the copyright headers need to be updated to the new format, please.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/samples/prebuiltdb/README.md Outdated Show resolved Hide resolved
gvenzl added 2 commits March 26, 2020 15:18
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
@gvenzl
Copy link
Member Author

gvenzl commented Mar 26, 2020

Addresses #640

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
OracleDatabase/SingleInstance/tests/runImageBuildTests.sh Outdated Show resolved Hide resolved
gvenzl added 4 commits March 27, 2020 12:41
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Djelibeybi
Djelibeybi previously approved these changes Mar 27, 2020
@Djelibeybi
Copy link
Member

Fine with me. You can merge once @mriccell reviews too.

Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
Djelibeybi
Djelibeybi previously approved these changes Apr 1, 2020
Signed-off-by: Gerald Venzl <gerald.venzl@oracle.com>
@mriccell mriccell merged commit 2015a55 into oracle:master Apr 1, 2020
@gvenzl gvenzl deleted the remove-volume-expose branch April 1, 2020 23:59
@chahn
Copy link

chahn commented Apr 2, 2020

@gvenzl could you please give me a hint on why you use LABELs for volumes and ports instead of VOLUME or EXPOSE? I haven't seen this before.

@Djelibeybi
Copy link
Member

@chahn the labels are to provide additional detail in a way that doesn't impose restrictions on how the image is actually used. They're there for decoration purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants